I personally went with the 840 Pro, but mostly because the 256gb 830s are quickly becoming impossible to find at a reasonable price.
The speeds are close enough to be comparable unless you are benchmarking the drive constantly.
There are three things I would consider:
- If you want to UEFI/Secure boot, there were limited cases where people reported issues running the 830 with GPT rather than MBR.
- The 840 Pro uses a smaller NAND die than the 830 which invariably will decrease it's lifespan when compared to the 830. Both will last longer than needed under anything but the heaviest of workloads.
- The 840 Pro can WRITE significantly faster. Now in general most people looking for a 512gb drive are wanting to use it to load games or applications in which case the write speed is largely irrelevant once everything is installed.
If none of those things matter to you, the 830 should be fine.