C++ question!

[WarDemon666]

I have to take in a postal code as a1b2c3 and output it as A1B 2C3

i have attached the code of what I have now, dont know how I could change it

also, how do you get a program to run outside of the visual studio debugger?

thanks!

 

[Barnaby W. Füi]

What is POSTAL_CODE? It looks like it's 7, but that doesn't make any sense. A postal code's length is 6. Give POSTAL_CODE a more meaningful name and value.

And you don't need to "change" a char array. You're taking input from cin and putting stuff into another string. Put the space in as you go, instead of adding it afterwards.

And post more of the context. I don't know what type your variables are or anything.

And why use char arrays in C++? That's what std::string is for.

 

[imported_jediknight]

You mean something like:
turning a,b,c,d (ie, array[0]=a, array[1]=b... ) into a,b <space>, c d?

First off, you need to have an array that is large enough to accomodate everything, including the space. Then

 

[imported_jediknight]

oops make that while (current_pos > position - 1)

 

[WarDemon666]

Originally posted by: BingBongWongFooey
What is POSTAL_CODE? It looks like it's 7, but that doesn't make any sense. A postal code's length is 6. Give POSTAL_CODE a more meaningful name and value.

And you don't need to "change" a char array. You're taking input from cin and putting stuff into another string. Put the space in as you go, instead of adding it afterwards.

And post more of the context. I don't know what type your variables are or anything.

And why use char arrays in C++? That's what std::string is for.

Guess were using it to get used to the char's in class. i dont know... postal code is 6 + 1 for the \0 at the end, according to the teacher...

jediknight:
we arent supposed to use functions yet, and I doubt thats the way she wants me to do it... its prolly something simpler :S

P.S. I know I could have used a function for this, but she does not want us to..

the getch() doesnt work and I dont know why,, any ideas?

Thanks!

 

[Barnaby W. Füi]

Originally posted by: WarDemon666
Guess were using it to get used to the char's in class. i dont know...

Well you're also using ".h" filenames for header includes and not using namespaces etc., so basically you're doing old-style c++. Modern c++ was standardized in 1998. I don't get why they still teach that stuff. (well, maybe I do actually)

postal code is 6 + 1 for the \0 at the end, according to the teacher...

Shouldn't it be MAX_POSTAL_CODE, just like the other MAX_* constants it's next to? Naming it POSTAL_CODE makes it pretty ambiguous.

 

[WarDemon666]

Originally posted by: BingBongWongFooey

Originally posted by: WarDemon666
Guess were using it to get used to the char's in class. i dont know...

Well you're also using ".h" filenames for header includes and not using namespaces etc., so basically you're doing old-style c++. Modern c++ was standardized in 1998. I don't get why they still teach that stuff. (well, maybe I do actually)

postal code is 6 + 1 for the \0 at the end, according to the teacher...

Shouldn't it be MAX_POSTAL_CODE, just like the other MAX_* constants it's next to? Naming it POSTAL_CODE makes it pretty ambiguous.

haha yeah. didnt even realise I did that lol

 

[asleepwalking00]

Originally posted by: WarDemon666
I have to take in a postal code as a1b2c3 and output it as A1B 2C3

I'm not sure if this is what you mean, but if you just want the outputted zip formatted with as space just add it to the output stream:

 

[WarDemon666]

so anyone know why the getch doesnt work?

also, how could I do it when getting the postal code?

Thanks

 

[mattg1981]

try using cin.ignore();

 

[WarDemon666]

Originally posted by: mattg1981
try using cin.ignore();

i use it just to get rid of whats in the buffer, the teacher told us to use getch at the end of the program to ask the user to press any key....

 

[Barnaby W. Füi]

Define "doesn't work."

 

[WarDemon666]

error defined! :

error C2065: 'getch' : undeclared identifier
Error executing cl.exe.

test.exe - 1 error(s), 0 warning(s)

 

[WarDemon666]

Ok i googled again, and i found that you have to include conio.h, but i dont remember the teacher talking about that.. also, now that it actually runs when i type quit it says nothing, it waits for a key and then displays press any key to continue twice..

 

[SinNisTeR]

crazy canadians...

 

[WarDemon666]

Originally posted by: SinNisTeR
crazy canadians...

:beer:

Had to use the flush command