Can't get a basic C++ program to work

[RapidSnail]

I can't get this damn program to work correctly. It's a past due, by a few hours, homework assignment for intro C++. The theme is do/while and while statements. Nothing advanced. The program itself should be simple but it doesn't work correctly. Please help.

By the way, I included in the end while statement a line of code:

cout << q << endl;

This is for debugging so I can see program output at each step. It will not be part of the final code.

Source

Edit: Moved source to pastebin. Problem solved.

 

[Crusty]

What's not working correctly? What is the program supposed to do?

 

[RapidSnail]

Calculate the greatest common divisor of two numbers: p and q. The value p must be greater than q (p > q) and both must be non-zero. The program acts very strangely, sometimes calculating the number sometimes not. You'd have to look at the source code that I linked for a better understanding.

 

[stevf]

that link doesnt work for me - just that site's home, no code I could see

 

[Crusty]

There's a download file link on the right side... but it points to a .BIN file.. enough to scare me away

 

[Dimmu]

The problem is occurring because if, for example, p = 12 and q = 10 then your while loop [while (p%q > 0)] will terminate prematurely at q = 6, because 12%6 = 0. The loop should be changed to [while (p%q >= 0)] and it will work as intended.

 

[RapidSnail]

Originally posted by: Dimmu
The problem is occurring because if, for example, p = 12 and q = 10 then your while loop [while (p%q > 0)] will terminate prematurely at q = 6, because 12%6 = 0. The loop should be changed to [while (p%q >= 0)] and it will work as intended.

Yep, figured it out just now. Thanks. Do you know how to calculate the GCD if q is negative, and p and q are negative? Shouldn't the GCD of 16 and -16 be 16? This calculator says otherwise.

 

[RapidSnail]

Originally posted by: Crusty
There's a download file link on the right side... but it points to a .BIN file.. enough to scare me away

I don't know what .BIN file is, but the link should be .cpp. If not, you can add the extension. But is there a way for me to post source code that preserves white space?

 

[Crusty]

Originally posted by: RapidSnail

Originally posted by: Crusty
There's a download file link on the right side... but it points to a .BIN file.. enough to scare me away

I don't know what .BIN file is, but the link should be .cpp. If not, you can add the extension. But is there a way for me to post source code that preserves white space?

Unfortunately not with fusecrap. The attach code is busted bigtime, and just pasting it into the forum msg won't preserve it either.

 

[RapidSnail]

Originally posted by: Crusty

Originally posted by: RapidSnail

Originally posted by: Crusty
There's a download file link on the right side... but it points to a .BIN file.. enough to scare me away

I don't know what .BIN file is, but the link should be .cpp. If not, you can add the extension. But is there a way for me to post source code that preserves white space?

Unfortunately not with fusecrap. The attach code is busted bigtime, and just pasting it into the forum msg won't preserve it either.

Any websites that will let me upload a copy/paste and not require download?

 

[Crusty]

I've seen some people use pastebin before.

 

[RapidSnail]

Originally posted by: Crusty
I've seen some people use pastebin before.

That's the exact site I was looking for! Changed source link above.