critique my UML diagrams please

[Alex]

Basically, its an online system where customers will fill in one (or both) of 2 forms which will be validated and having passed validation will be stored in our database.

There are plans for more complex interactions after that such as retrieving the information and displaying it in a variety of formats but the UML diagrams here are basically for this 1st step:

Activity Diagram

Case of Use

Class Diagram

Sorry, the captions are in portuguese but it should really be self-explanatory...

Just looking for some feedback here, read up a lot on UML the past few days and I have to present this to my company on Monday so I don't really wanna make a fool of myself!

thanks!

-Alex

 

[Atheus]

The first one is a bit wonky but otherwise they're not bad.

Don't worry about making a fool of yourself, this sounds like a really simple web form and you can hardly mess it up... in fact it seems a bit pedantic of them to ask for UML diagrams...

 

[Alex]

Originally posted by: Atheus
The first one is a bit wonky but otherwise they're not bad.

Don't worry about making a fool of yourself, this sounds like a really simple web form and you can hardly mess it up... in fact it seems a bit pedantic of them to ask for UML diagrams...

thanks!

thing is i've only worked with UML in theory so actually getting it done in practice for something important is a whole new ballgame to me...

they're very pedantic about methodology and documentation (frequent SCRUM meetings, weekly product backlogs and sprint backlogs and constant evaluations) so its good in a way because instead of just diving in and coding i do actually spend aproximately 50% of my time planning and documenting everything thoroughly

 

[Alex]

*bump* please some other feedback???

 

[Brett]

Is there a difference between Usuario and Usuario2? If not, there should only be one, and that one actor performs both of the actions. If they are different types of actor, for instance "User" and "Administrator" they should have clear names that indicate the difference. User1 and User2 are not clear. If this is a case where having 2 "Usuario" is correct, you should try to come up with something in their name that differentiates them. That being said, if you are trying to say something like "User1 sends a message" and "User2 recieves the message" this should be shown with 1 actor, because its a User actor.

I also prefer, in use case diagrams, to label my include arrows (dashed arrows) with <<include>>

In your class diagram, I would put <<import>> on the arrow between Lead and Validation, but thats my style.

Finally, In an activity diagram, I don't think it is appropriate to be putting things like <<datastore>>, these should all be actions, like a flow chart. I would just have it be a normal action with "Insert into Database"

 

[Alex]

Originally posted by: Brett
Is there a difference between Usuario and Usuario2? If not, there should only be one, and that one actor performs both of the actions. If they are different types of actor, for instance "User" and "Administrator" they should have clear names that indicate the difference. User1 and User2 are not clear. If this is a case where having 2 "Usuario" is correct, you should try to come up with something in their name that differentiates them. That being said, if you are trying to say something like "User1 sends a message" and "User2 recieves the message" this should be shown with 1 actor, because its a User actor.

I also prefer, in use case diagrams, to label my include arrows (dashed arrows) with <<include>>

In your class diagram, I would put <<import>> on the arrow between Lead and Validation, but thats my style.

Finally, In an activity diagram, I don't think it is appropriate to be putting things like <<datastore>>, these should all be actions, like a flow chart. I would just have it be a normal action with "Insert into Database"

I used two users (Usuario and Usuario2) to illustrate the 2 different tasks that can be accomplished:
there are two very similar forms with the second having a few additional fields.

I just wanted to illustrate that whether the user plans to fill form 1 or form 2 that the resulting action is the same... maybe ill have two different actions to correspond to each form.

And thanks for the tip on the <<import>> label...

I have to present this tomorrow to some of the top IT guys at my company who definitely know their stuff, but its kind of a test since i'm the one who's going to implement the system, they want me to plan it from the ground up