Critique my website!

Saint Michael

Golden Member
Aug 4, 2007
1,877
1
0
It's clean and presentable, except the company logos. You should put a note at the bottom saying those images don't belong to you (that is, that you do not own the trademark or copyright or whatever to those logos).
 

TheNewbie

Senior member
Jul 17, 2007
740
0
0
Ok, I like it, its clean cut and neat. Content is boring, but I guess it never meant to be an entertaining site, so you're fine. Maybe add a little color to the titles, to make it a bit more vivid. Otherwise for its purpose, it seems to be nicely designed.

*Btw, you are aware of the bug on your main page with the news uploading thing right?
 

mooglemania85

Diamond Member
May 3, 2007
3,324
0
0
Get rid of the University of Waterloo logo. Doesn't make sense to have it as a link to your index page.
 

JoeKing

Lifer
Oct 9, 1999
10,641
1
81
I don't like how the tables jump ever so slightly from left to right for me when I click on one of your links. it's a little thing, but would make the experience so much better if fixed.
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: TheNewbie
Ok, I like it, its clean cut and neat. Content is boring, but I guess it never meant to be an entertaining site, so you're fine. Maybe add a little color to the titles, to make it a bit more vivid. Otherwise for its purpose, it seems to be nicely designed.

*Btw, you are aware of the bug on your main page with the news uploading thing right?

What bug? I dont think i know lol
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: JoeKing
I don't like how the tables jump ever so slightly from left to right for me when I click on one of your links. it's a little think, but would make the experience so much better.

that occurs when the page is too long and the scroll bar is added

cause right now everything is inside a <center></center> block...yeah i guess ur right . it does look bad . but i cant think of any easy fix right now.....
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: Saint Michael
It's clean and presentable, except the company logos. You should put a note at the bottom saying those images don't belong to you (that is, that you do not own the trademark or copyright or whatever to those logos).

i will add that next . thanks!
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: mooglemania85
Get rid of the University of Waterloo logo. Doesn't make sense to have it as a link to your index page.

yeah . i know that part is random and ugly...but i dont have any idea what to put there . it looks ugly without some sort of header as well . any suggestions?
 

AgaBoogaBoo

Lifer
Feb 16, 2003
26,108
5
81
I saw you mention the Robotics team - I was on team 868, came second place nationally in 05 I think? It's been a while, maybe 04?

Great experience and it was loads of fun being able to build something like that
 

JoeKing

Lifer
Oct 9, 1999
10,641
1
81
Originally posted by: aznium
Originally posted by: JoeKing
I don't like how the tables jump ever so slightly from left to right for me when I click on one of your links. it's a little think, but would make the experience so much better.

that occurs when the page is too long and the scroll bar is added

cause right now everything is inside a <center></center> block...yeah i guess ur right . it does look bad . but i cant think of any easy fix right now.....

you can define the width of you main table to a specific width instead of a %, something like 1024 should be generic enough for everyone to view properly.
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: AgaBoogaBoo
I saw you mention the Robotics team - I was on team 868, came second place nationally in 05 I think? It's been a while, maybe 04?

Great experience and it was loads of fun being able to build something like that



lol . yeah great experience . mine was 849 . i joined the team in grade 9 (2002?) but in grade 10/11 there was no team .... Ontario budget cut backs fired a lot of teachers and we had no teacher to supervise us . i got the team going in my grade 12 year . lol

our team always had money problems . we never competed in the US competition . too bad .

 

lambchops511

Senior member
Apr 12, 2005
659
0
0
Originally posted by: JoeKing
Originally posted by: aznium
Originally posted by: JoeKing
I don't like how the tables jump ever so slightly from left to right for me when I click on one of your links. it's a little think, but would make the experience so much better.

that occurs when the page is too long and the scroll bar is added

cause right now everything is inside a <center></center> block...yeah i guess ur right . it does look bad . but i cant think of any easy fix right now.....

you can define the width of you main table to a specific width instead of a %, something like 1024 should be generic enough for everyone to view properly.

the width is already a constant value...

the thing shifts not because the width of the table changes...but because the width of the screen\viewable area changes



ie. screen is 10 units and the table is 6 units ... therefore left is 2 units

but once the page is long, and a scrollbar is attached to the side (assume a huge/wide scrollbar of 2 units)

the screen is now 8 units and the table is still 6 units...therefore left is 1 unit.....thus the shift
 

mooglemania85

Diamond Member
May 3, 2007
3,324
0
0
Originally posted by: aznium
Originally posted by: mooglemania85
Get rid of the University of Waterloo logo. Doesn't make sense to have it as a link to your index page.

yeah . i know that part is random and ugly...but i dont have any idea what to put there . it looks ugly without some sort of header as well . any suggestions?

Have someone make a header for you. Offer to pay $5 via paypal. Let the hilarity ensue.

Or just remove it and put an Index Link in your menu bar.
 

lajos

Junior Member
Jul 30, 2007
21
0
0
I think there are some fine tunings to be done like the header. It seems that it is not properly centered or is it intended to be as it is. Also, as I surf through the site I did not find the homepage link when I want to get back to where I was initially in the first place.
 

AgaBoogaBoo

Lifer
Feb 16, 2003
26,108
5
81
Originally posted by: aznium
Originally posted by: AgaBoogaBoo
I saw you mention the Robotics team - I was on team 868, came second place nationally in 05 I think? It's been a while, maybe 04?

Great experience and it was loads of fun being able to build something like that
lol . yeah great experience . mine was 849 . i joined the team in grade 9 (2002?) but in grade 10/11 there was no team .... Ontario budget cut backs fired a lot of teachers and we had no teacher to supervise us . i got the team going in my grade 12 year . lol

our team always had money problems . we never competed in the US competition . too bad .
Wow, both of our teams must have started at very close dates!

And yeah, money was a struggle, we were fortunate to have a few kids who knew a LOT of people, and we made it through. At one point, one student put his landscaping business' entire credit line up for us with the hope that we would all raise enough to repay him, and we did.

Each year was harder and harder to keep it going, especially that same problem of getting a teacher to "supervise" it. It's unfortunate local businesses aren't more willing to support it, this program could really take off in some places if there was more funding.
 

Rip the Jacker

Diamond Member
Dec 29, 2004
5,415
1
76
Your markup should be better for a guy who's worked as a Web Developer, tables are so 1990ish and even though you are using some divisions you're killing the whole point of using css for layout because of the tables.

[Front End Rant]
Markup-wise, lose the tables, use a DOCTYPE because your page is in quirks mode (meaning browsers can do whatever the fvck they want because you're not adhering to any DTD), and start using CSS purely for layout. Wrap h1's around your <img> and provide alternative text for screen readers, or incase the image was deleted/corrupted. Your nav is VERY simple, just have a <ul> with 4 list items that hold the anchors (links) and use the :hover property on the anchor to change the background instead of resorting to Javascript. I think this makes it a little faster because no JS parsing has to be done, and your stylesheet will be cached and it's just a simple background color effect, nothing too difficult and people who have JS disabled will still see that hover effect. Markup your elements more semantically, don't use the <center> element because its deprecated and its presentational (you want to seperate content and presentation). Have a wrapper with either a percentage or ems as the width, this will make it fluid/elastic so it can adapt to any resolution (if its very small try using min-width).

Do not use a width such as 1024, that's too high IMO. You should be safe with either 750 or 950 pixels or just use a percentage such as 60% (You don't even have multiple columns that are fixed width, meaning that it doesn't really matter if you go from fixed width to a percent/ems as long as you kill the table, it will adjust).

[Design Rant]
I'm no (great) designer but I'd make these changes...

-Get rid of that Waterloo logo.
-Go to a stock website and find SOME nature or something that you can use as your header background, go into Photoshop and put 'William Chan' on top and make it blend in using some borders or whatever. There is ABSOLUTELY no color if you remove that Waterloo logo, everything is BLACK and WHITE and BORING. Get some colors goin! If you can't decide, just go to any random site and "get inspired" (this does not mean steal images) but just try to get some type of color theme going..
-Typography wise the text under your name on your resume is too godamn small, bump it up at least one size

[Usability-wise (mixed with front end)]
-Please REMOVE the ONCLICK="" attributes on ANY element ( not only the nav ) but your logo as well, because ONCLICK="location.href='index.php'" requires javascript to be supported. If it's not there it will be a DEAD link and NO ONE should be using ONCLICK as a replacement for the href attribute. Also, search engines (well it doesnt matter for this specific site but incase you do develop more in the future) won't be able to crawl because they don't support JS and they most likely look for the HREF="" attribute on anchors so they can crawl the whole site.
-On your navigation, indicate what page the user is on by assigning a class to the navigation element (li)

<ul id="main-nav">
<li class="current"><a href="profile.php">profile</a></li>
<li><a href="portfolio.php">portfolio</a></li>
<li><a href="resume.php">resume</a></li>
<li><a href="contact.php">contact</a></li>
</ul>

ul#main-nav { list-style:none; height:20px; overflow:hidden;}
ul#main-nav a { display:block; width:100px; height:15px; }
ul#main-nav li { float:left; }
ul#main-nav li.current a { background-color:#333; }

That should probably do it, might have to set a width on ul#main-nav li { } though (This is off the top of my head)

P.S. - the reason your header doesn't stay in the same place is because on some pages the content causes a scrollbar which takes up the width of the browser and forces the table to shift a few pixels. This is common, though. If you really care you can either kill the scrollbar (this I don't recommend).. I believe it's html, body { overflow-y:hidden; } or try just overflow:hidden; on html/body .. a better solution would be to add more content to your homepage or any page, or set a height on html/body elements such as 100% (maybe 101% or add some spacing/padding) so every page has a scrollbar.

Anyways it's getting late(very late) and I should be heading to sleep. later.
 

ed21x

Diamond Member
Oct 12, 2001
5,411
8
81
just a small suggestion... standardize the font for everything... that is, the navigation links on the top should be arial or whatever you used for the body. Other than that, I like the simplicity of the site.
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
thanks Rip the Jacker...i like those criticism

added doctype
added description meta tag
added content-type tag

javascript ***** - even if browser doesnt have javascript support (highly unlikely), there is still an <a> behind it...so search engines can still crawl it

still need to replace tables with css
havent added more colours yet . i know its BW right now . but i think its clean? or too clean?
still need to fix scrollbar problem

changed the logo to the first thing i found on istockphoto lol


edit: just noticed the IE problems...fixing it....

edit2: seems like IE isnt behaving...i've removed doctype for now...too tired to do anymore work.zzzz
 

911paramedic

Diamond Member
Jan 7, 2002
9,448
1
76
Originally posted by: RossMAN
http://www.websitegrader.com/


Mine:
Website Grade 66
Google Page Rank 2
Google Inbound Links 11
Yahoo Inbound Links 5,459
Google Indexed Pages 534

Readability Level : High School + 1 Year College <--LOL, keep out the riff-raff.

Cool link RossMan, thanks.

P.S. OP, site looks a bit on the "plain" side to me. (Didn't mean to hijack this thread...)

EDIT: The links turn white (same as background) when moused over, you may want to fix that.
 

lambchops511

Senior member
Apr 12, 2005
659
0
0
changed a bunch of stuff

replaced a bunch of tables/trs/tds with css and divs

still have some more tables to go.

added doctype and a much of meta tags

changed the header.png . looks better now?
 
sale-70-410-exam    | Exam-200-125-pdf    | we-sale-70-410-exam    | hot-sale-70-410-exam    | Latest-exam-700-603-Dumps    | Dumps-98-363-exams-date    | Certs-200-125-date    | Dumps-300-075-exams-date    | hot-sale-book-C8010-726-book    | Hot-Sale-200-310-Exam    | Exam-Description-200-310-dumps?    | hot-sale-book-200-125-book    | Latest-Updated-300-209-Exam    | Dumps-210-260-exams-date    | Download-200-125-Exam-PDF    | Exam-Description-300-101-dumps    | Certs-300-101-date    | Hot-Sale-300-075-Exam    | Latest-exam-200-125-Dumps    | Exam-Description-200-125-dumps    | Latest-Updated-300-075-Exam    | hot-sale-book-210-260-book    | Dumps-200-901-exams-date    | Certs-200-901-date    | Latest-exam-1Z0-062-Dumps    | Hot-Sale-1Z0-062-Exam    | Certs-CSSLP-date    | 100%-Pass-70-383-Exams    | Latest-JN0-360-real-exam-questions    | 100%-Pass-4A0-100-Real-Exam-Questions    | Dumps-300-135-exams-date    | Passed-200-105-Tech-Exams    | Latest-Updated-200-310-Exam    | Download-300-070-Exam-PDF    | Hot-Sale-JN0-360-Exam    | 100%-Pass-JN0-360-Exams    | 100%-Pass-JN0-360-Real-Exam-Questions    | Dumps-JN0-360-exams-date    | Exam-Description-1Z0-876-dumps    | Latest-exam-1Z0-876-Dumps    | Dumps-HPE0-Y53-exams-date    | 2017-Latest-HPE0-Y53-Exam    | 100%-Pass-HPE0-Y53-Real-Exam-Questions    | Pass-4A0-100-Exam    | Latest-4A0-100-Questions    | Dumps-98-365-exams-date    | 2017-Latest-98-365-Exam    | 100%-Pass-VCS-254-Exams    | 2017-Latest-VCS-273-Exam    | Dumps-200-355-exams-date    | 2017-Latest-300-320-Exam    | Pass-300-101-Exam    | 100%-Pass-300-115-Exams    |
http://www.portvapes.co.uk/    | http://www.portvapes.co.uk/    |